improve federation error messages #767
Conversation
|
@schiessle, thanks for your PR! By analyzing the annotation information on this pull request, we identified @DeepDiver1975, @MorrisJobke and @nickvergessen to be potential reviewers |
|
LukasReschke
added
2. developing
schiessle
force-pushed
the
federation-error-messages
branch
from
41f8fb4
to
cf1cc54
Compare
schiessle
added
3. to review
schiessle
force-pushed
the
federation-error-messages
branch
2 times, most recently
from
0bb2b93
to
f3b1864
Compare
|
|
||
| } | ||
| } catch (\Exception $e) { | ||
| return false; |
There was a problem hiding this comment.
Could we somehow log the error message here? This would make it a lot easier to debug when needed (so debug log level is enough)
schiessle
force-pushed
the
federation-error-messages
branch
from
f3b1864
to
50044fb
Compare
|
👍 |
| @@ -89,7 +89,7 @@ public function addServer($url) { | |||
| if ($result) { | |||
| return (int)$this->connection->lastInsertId('*PREFIX*'.$this->dbTable); | |||
| } else { | |||
| $message = 'Internal failure, Could not add ownCloud as trusted server: ' . $url; | |||
| $message = 'Internal failure, Could not add trusted server: ' . $url; | |||
There was a problem hiding this comment.
Could not add trusted server = The server is trusted but you were not able to add
Could not add **as** trusted server = The server could not be added because there is a problem with the trust
There was a problem hiding this comment.
The server could not be added because there is a problem with the trust
There is no problem with the trust, the error happens most likely if you point to a URL which doesn't run a Nextcloud/ownCloud. So you could for example argue that if you add your webapage it is a page you trust, but well it is no Nextcloud so it can't be added. Anyway, this is just a log message to identify the code path which failed.
|
👍 |
|
Backport? @karlitschek |
|
perfect. please backport 👍 :-) |
|
On it 💪 |
|
Thanks @Mar1u5 😃 |
|
#788 is the backport to |
|
@Mar1u5 When the backport PRs are opened the backport-request label could be removed. This makes it then easier to find not yet backported PRs ;) |
I know, but I am not sure, wheter we also need this in |
|
It is a small fix, I would also backport it to stable9 |
|
Okay... Thats something for you @schiessle ... I experience conflicts when I cherry-pick the commit to |
|
ah yes, because almost all file name changed between 9 and 10 because of PSR4 compatibility... Let's keep it this way. This is also nothing urgent, just a error string. |
…ages improve federation error messages
improve error message, in case a wrong URL gets added to the "add trusted server" input field #735