Comments AutoCompletion #6982

blizzz · 2017-10-27T10:01:30Z

Follow up to #6779, both backend and gui, for #2443

I also did a quick demo video

Type @ and a char to start auto completion for a user
Mentiones are rendered just like as we use avatar + displayname everywhere
works also when editing users
user shared with and commented are sorted on top (given their are part of the result set)
it's themed!
known issue on FF: to remove a mention, it must be marked first. Apparently a browser bug. On Chromium, backspace works fine.

Please test and review

* introduce a Controller for requests * introduce result sorting mechanism * extend Comments to retrieve commentors (actors) in a tree * add commenters sorter * add share recipients sorter Signed-off-by: Arthur Schiwon <[email protected]>

so walking it is reusable Signed-off-by: Arthur Schiwon <[email protected]>

Signed-off-by: Arthur Schiwon <[email protected]>

we will need it for nice formatting of the mentioned user Signed-off-by: Arthur Schiwon <[email protected]>

i.e. avatar with displaymenu and contactsmenu-popover Signed-off-by: Arthur Schiwon <[email protected]>

also ensures proper rendering, even of edited comments Signed-off-by: Arthur Schiwon <[email protected]>

Signed-off-by: Arthur Schiwon <[email protected]>

codecov · 2017-10-27T11:51:11Z

Codecov Report

❗ No coverage uploaded for pull request base (master@52b679a). Click here to learn what that means.
The diff coverage is 58.15%.

@@            Coverage Diff            @@
##             master    #6982   +/-   ##
=========================================
  Coverage          ?   50.62%           
  Complexity        ?    24289           
=========================================
  Files             ?     1576           
  Lines             ?    92882           
  Branches          ?     1358           
=========================================
  Hits              ?    47022           
  Misses            ?    45860           
  Partials          ?        0

Impacted Files	Coverage Δ	Complexity Δ
lib/private/Share20/Manager.php	`86.65% <ø> (ø)`	`234 <0> (?)`
core/routes.php	`0% <ø> (ø)`	`0 <0> (?)`
apps/user_ldap/lib/Connection.php	`57.55% <ø> (ø)`	`118 <0> (?)`
...iles_sharing/composer/composer/autoload_static.php	`0% <ø> (ø)`	`1 <0> (?)`
config/config.sample.php	`0% <ø> (ø)`	`0 <0> (?)`
...pps/comments/composer/composer/autoload_static.php	`0% <ø> (ø)`	`1 <0> (?)`
apps/user_ldap/lib/Access.php	`18.18% <0%> (ø)`	`304 <0> (?)`
...s/comments/composer/composer/autoload_classmap.php	`0% <0%> (ø)`	`0 <0> (?)`
lib/private/legacy/app.php	`54.18% <0%> (ø)`	`221 <0> (?)`
apps/comments/appinfo/app.php	`13.63% <0%> (ø)`	`0 <0> (?)`
... and 11 more

Signed-off-by: Arthur Schiwon <[email protected]>

background: we have a flat hierarchy of comments, not a tree. therefore we can also remove again the unnecessary additions. Signed-off-by: Arthur Schiwon <[email protected]>

jancborchardt

Looks nice from the demo video! I’d say further fixes should be done in follow-ups cause this is too big already. :)

nickvergessen · 2017-10-31T11:12:25Z

Should only ship the minified js file, instead of the examples and other unneeded stuff.

nickvergessen · 2017-10-31T11:17:02Z

lib/private/Server.php

@@ -1011,6 +1011,11 @@ public function __construct($webRoot, \OC\Config $config) {
 		});
 		$this->registerAlias('CollaboratorSearch', \OCP\Collaboration\Collaborators\ISearch::class);

+		$this->registerService(\OCP\Collaboration\AutoComplete\IManager::class, function (Server $c) {
+			return new Collaboration\AutoComplete\Manager($c);


please import completely

actually you should be able to drop this completely because of our magic automatic injection

Signed-off-by: Arthur Schiwon <[email protected]>

nickvergessen · 2017-10-31T13:18:47Z

If you match the full user id with @test1 the user is not suggested anymore, but @test brings them up
The avatar is not rendered anymore after you clicked/selected one of the options.

Signed-off-by: Arthur Schiwon <[email protected]>

blizzz · 2017-10-31T14:01:11Z

@nickvergessen great testing 👍 fixed with recent commits

rullzer

Awesome

Signed-off-by: Arthur Schiwon <[email protected]>

blizzz · 2017-11-01T16:00:46Z

🍻

blizzz added 19 commits October 22, 2017 14:13

AutoCompletion backend

fd6daf8

* introduce a Controller for requests * introduce result sorting mechanism * extend Comments to retrieve commentors (actors) in a tree * add commenters sorter * add share recipients sorter Signed-off-by: Arthur Schiwon <[email protected]>

split walking the tree from operating on it

8f0a9ae

so walking it is reusable Signed-off-by: Arthur Schiwon <[email protected]>

ensure that sorting is stable

8722458

Signed-off-by: Arthur Schiwon <[email protected]>

fix class name in info.xml

04fafdd

Signed-off-by: Arthur Schiwon <[email protected]>

add At.js and dependencies

8e60a2b

Signed-off-by: Arthur Schiwon <[email protected]>

setup atwho autocomplete

d1afbed

Signed-off-by: Arthur Schiwon <[email protected]>

contenteditable divs should look like textareas

df0e72d

Signed-off-by: Arthur Schiwon <[email protected]>

turn textarea to contenteditable div

ec56075

we will need it for nice formatting of the mentioned user Signed-off-by: Arthur Schiwon <[email protected]>

when writing a comment, render mentions as they'd appear anywhere

8d9f485

i.e. avatar with displaymenu and contactsmenu-popover Signed-off-by: Arthur Schiwon <[email protected]>

convert mentions after save to the plain format we use

ccbcce9

also ensures proper rendering, even of edited comments Signed-off-by: Arthur Schiwon <[email protected]>

fix contactsmenu-popup

de8a475

Signed-off-by: Arthur Schiwon <[email protected]>

fix unstable comment order

eb8f124

Signed-off-by: Arthur Schiwon <[email protected]>

enable autocomplete when editing comments

fb40afc

Signed-off-by: Arthur Schiwon <[email protected]>

avoid unnecessary recursion

3628d4d

Signed-off-by: Arthur Schiwon <[email protected]>

add search parameter to autocomplete controller

fa2f039

Signed-off-by: Arthur Schiwon <[email protected]>

add config parameter sample

dcc4e7d

Signed-off-by: Arthur Schiwon <[email protected]>

autocomplete on demand

aa2fd30

Signed-off-by: Arthur Schiwon <[email protected]>

fix sorting

7f58c41

Signed-off-by: Arthur Schiwon <[email protected]>

apply our theming

eace507

Signed-off-by: Arthur Schiwon <[email protected]>

blizzz added 2. developing Work in progress enhancement feature: comments labels Oct 27, 2017

blizzz added this to the Nextcloud 13 milestone Oct 27, 2017

blizzz added 2 commits October 27, 2017 12:34

avatar css fixes

bd951e9

Signed-off-by: Arthur Schiwon <[email protected]>

configurable amount of autocomplete results in comments

ca72c01

Signed-off-by: Arthur Schiwon <[email protected]>

blizzz added 4 commits October 27, 2017 16:03

fix sharerecipientssorter tests

20e7a0c

Signed-off-by: Arthur Schiwon <[email protected]>

add acceptance tests

76c803f

Signed-off-by: Arthur Schiwon <[email protected]>

preserve line breaks

61db861

Signed-off-by: Arthur Schiwon <[email protected]>

fix comment sorter

d5f1cef

background: we have a flat hierarchy of comments, not a tree. therefore we can also remove again the unnecessary additions. Signed-off-by: Arthur Schiwon <[email protected]>

blizzz requested review from rullzer, nickvergessen, jancborchardt, georgehrke, ChristophWurst, schiessle, juliusknorr, skjnldsv and danxuliu October 30, 2017 17:16

jancborchardt approved these changes Oct 30, 2017

View reviewed changes

nickvergessen reviewed Oct 31, 2017

View reviewed changes

blizzz added 3 commits October 31, 2017 12:28

only ship minimized js files

4b24dea

Signed-off-by: Arthur Schiwon <[email protected]>

simplify registration of manager in server container

bcfac75

Signed-off-by: Arthur Schiwon <[email protected]>

remove more vendor-imported files that aren't necessary

d0f2f5f

Signed-off-by: Arthur Schiwon <[email protected]>

blizzz force-pushed the autocomplete-gui branch from f8e4be1 to d0f2f5f Compare October 31, 2017 13:06

blizzz added 2 commits October 31, 2017 14:42

fix avatar loading for generic placeholders

582d2d3

Signed-off-by: Arthur Schiwon <[email protected]>

meanwhile we can have exact matches. also show those.

25aad12

Signed-off-by: Arthur Schiwon <[email protected]>

rullzer approved these changes Oct 31, 2017

View reviewed changes

adjust jsunit tests

2b4b3b1

Signed-off-by: Arthur Schiwon <[email protected]>

blizzz force-pushed the autocomplete-gui branch from 947b30c to 2b4b3b1 Compare November 1, 2017 10:44

blizzz added 2 commits November 1, 2017 15:37

Merge branch 'master' into autocomplete-gui

e2805f0

update autoloader

f1570c2

Signed-off-by: Arthur Schiwon <[email protected]>

blizzz force-pushed the autocomplete-gui branch from a28f3f9 to f1570c2 Compare November 1, 2017 15:30

blizzz merged commit db48575 into master Nov 1, 2017

blizzz deleted the autocomplete-gui branch November 1, 2017 16:00

blizzz mentioned this pull request Nov 3, 2017

Bring LDAP user attribute updates ("sync") to the background #7057

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments AutoCompletion #6982

Comments AutoCompletion #6982

blizzz commented Oct 27, 2017 •

edited

Loading

codecov bot commented Oct 27, 2017 •

edited

Loading

jancborchardt left a comment

nickvergessen commented Oct 31, 2017

nickvergessen Oct 31, 2017

nickvergessen Oct 31, 2017

nickvergessen commented Oct 31, 2017

blizzz commented Oct 31, 2017

rullzer left a comment

blizzz commented Nov 1, 2017

Comments AutoCompletion #6982

Comments AutoCompletion #6982

Conversation

blizzz commented Oct 27, 2017 • edited Loading

codecov bot commented Oct 27, 2017 • edited Loading

Codecov Report

jancborchardt left a comment

Choose a reason for hiding this comment

nickvergessen commented Oct 31, 2017

nickvergessen Oct 31, 2017

Choose a reason for hiding this comment

nickvergessen Oct 31, 2017

Choose a reason for hiding this comment

nickvergessen commented Oct 31, 2017

blizzz commented Oct 31, 2017

rullzer left a comment

Choose a reason for hiding this comment

blizzz commented Nov 1, 2017

blizzz commented Oct 27, 2017 •

edited

Loading

codecov bot commented Oct 27, 2017 •

edited

Loading