Harden count user logic on upgrade #6002
Conversation
lib/base.php
Outdated
| $totalUsers = array_sum($stats); | ||
| $tooBig = ($totalUsers > 50); | ||
| } catch (\Doctrine\DBAL\Exception\TableNotFoundException $e) { | ||
| \OC::$server->getLogger()->logException($e, ['level' => \OCP\Util::INFO, 'app' => 'core'); |
There was a problem hiding this comment.
💣 💣
ParseError: syntax error, unexpected ')', expecting ']' in /drone/src/github.com//pull/6002/lib/base.php:350
Signed-off-by: Morris Jobke <[email protected]>
MorrisJobke
force-pushed
the
fix-count-user
branch
from
17fe45c
to
46b63e0
Compare
Codecov Report
@@ Coverage Diff @@
## master #6002 +/- ##
===========================================
+ Coverage 53.11% 56.7% +3.58%
===========================================
Files 1404 61 -1343
Lines 88166 7520 -80646
Branches 1327 1327
===========================================
- Hits 46832 4264 -42568
+ Misses 41334 3256 -38078 |
|
I don't get what this is for. |
I just want to avoid, that upstream somehow renames this table and then our backend will not be able to count anymore. But we can also not run this code and fix it once it happens. It could also be the case, that a column is renamed or so. |
|
Makes no sense at all -> closing |
In addition to #6001 and #5695