Install nextcloud via migrations instead of the db_structure.xml #5772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
3. to review
MorrisJobke
previously approved these changes
Jul 18, 2017
|
@MorrisJobke I can replace all placeholders with |
nickvergessen
commented
Jul 19, 2017
| @@ -58,7 +58,6 @@ | |||
| 'COPYING-README', | |||
| 'core', | |||
| 'cron.php', | |||
| 'db_structure.xml', | |||
There was a problem hiding this comment.
@LukasReschke mentioning you as requested for potential build script adjustments
There was a problem hiding this comment.
I guess for this case no adjustment is needed, because it was a shipped file. We only should test the updater to check if the file list needs to be updated somehow.
nickvergessen
added
2. developing
|
db_structure.xml is still used by db convert and fix charset commands, will fix. |
nickvergessen
dismissed
MorrisJobke’s stale review
Dismissing review because there were many changes afterwards
|
BTW this is another step towards #2270 |
|
Migrations? yes. This here? no. |
Codecov Report
@@ Coverage Diff @@
## master #5772 +/- ##
============================================
- Coverage 57.06% 53.23% -3.84%
- Complexity 21017 22751 +1734
============================================
Files 1245 1403 +158
Lines 71040 87484 +16444
Branches 0 1327 +1327
============================================
+ Hits 40537 46569 +6032
- Misses 30503 40915 +10412
|
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Morris Jobke <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
…chema Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
…ctly Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
nickvergessen
force-pushed
the
migrations-install
branch
from
fb0bbe5
to
d254797
Compare
nickvergessen
added
3. to review
|
Should be ready for merge now |
rullzer
approved these changes
Jul 25, 2017
LukasReschke
approved these changes
Jul 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing Nextcloud now uses migrations only instead of the old db_structure.xml
The old file was not taken into consideration on updates anymore anyway, which caused a problem for @fancycode and @Ivansss with sqlite, after the accounts table was dropped it was not recreated on update.
This is now fixed, because all the structure is in a migration file.
Fix #5646
Fix #4914