allow to disable upload to lookup server, by default it is enabled #5575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bjoern Schiessle <[email protected]>
Signed-off-by: Bjoern Schiessle <[email protected]>
schiessle
added
3. to review
| @@ -931,7 +931,7 @@ public function userDeletedFromGroup($uid, $gid) { | |||
| */ | |||
| public function isOutgoingServer2serverShareEnabled() { | |||
| $result = $this->config->getAppValue('files_sharing', 'outgoing_server2server_share_enabled', 'yes'); | |||
| return ($result === 'yes') ? true : false; | |||
| return ($result === 'yes'); | |||
There was a problem hiding this comment.
you can remove the brackets aswell ;)
nickvergessen
approved these changes
Jul 1, 2017
ChristophWurst
approved these changes
Jul 4, 2017
ChristophWurst
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In large enterprises or other organizations it is often forbidden to publish personal user data on a third party service. Therefore it makes sense to backport this setting to disable the lookup server upload.
(partial) backport of #4250