feat(settings): add big file upload setup checks #49372
Merged
+84
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
requested review from
icewind1991 and
nfebe
and removed request for
a team
skjnldsv
force-pushed
the
feat/php-setup-file-upload
branch
from
106e651
to
3e8149e
Compare
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to stable28 |
skjnldsv
force-pushed
the
feat/php-setup-file-upload
branch
from
3e8149e
to
3d988ae
Compare
szaimen
reviewed
Nov 19, 2024
szaimen
approved these changes
Nov 19, 2024
|
@skjnldsv Just an idea: can we also somehow check web server body limits and timeouts? (These are also important to test afaik) |
Those variables are not accessible from php |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
come-nc
reviewed
Nov 19, 2024
No, there is always a fallback by php defaults if the value is not defined |
skjnldsv
force-pushed
the
feat/php-setup-file-upload
branch
from
3d988ae
to
96daddb
Compare
skjnldsv
force-pushed
the
feat/php-setup-file-upload
branch
from
96daddb
to
fb62fc2
Compare
come-nc
reviewed
Nov 19, 2024
Signed-off-by: skjnldsv <[email protected]>
skjnldsv
force-pushed
the
feat/php-setup-file-upload
branch
from
fb62fc2
to
4a88848
Compare
come-nc
approved these changes
Nov 19, 2024
This was referenced Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.nextcloud.com/server/latest/admin_manual/configuration_files/big_file_upload_configuration.html
We should have added that a long time ago 😮💨