Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh: Improvements on sharing details #49351

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented Nov 18, 2024

@nfebe nfebe added 3. to review Waiting for reviews feature: sharing labels Nov 18, 2024
@nfebe nfebe force-pushed the fix/no-issue/no-reshare-perms-4-email-shares branch from 815f1eb to d951399 Compare November 18, 2024 16:51
@nfebe nfebe changed the title refactor: Use new ShareType across file_sharing enh: Improvements on sharing details Nov 18, 2024
@nfebe nfebe force-pushed the fix/no-issue/no-reshare-perms-4-email-shares branch 3 times, most recently from aef75b5 to e641b8c Compare November 18, 2024 17:14
Copy link
Contributor Author

@nfebe nfebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refactor is bigger than I thought it would be. :)

@nfebe nfebe force-pushed the fix/no-issue/no-reshare-perms-4-email-shares branch 2 times, most recently from 6af29f9 to 386eac0 Compare November 18, 2024 18:03
@nfebe nfebe marked this pull request as draft November 18, 2024 18:24
@nfebe nfebe force-pushed the fix/no-issue/no-reshare-perms-4-email-shares branch from 386eac0 to c526982 Compare November 18, 2024 19:17
@nfebe nfebe marked this pull request as ready for review November 18, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant