Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(job): Check if carddata is resource and read it to string #49332

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

wolandtel
Copy link

Check if oc_cards.carddata has been read as resource and read it to string.

Check if oc_cards.carddata has been read as resource and read it to string.

Signed-off-by: Mikhail Kotelnikov <[email protected]>
@solracsf solracsf added this to the Nextcloud 31 milestone Nov 16, 2024
@solracsf solracsf added 3. to review Waiting for reviews feature: carddav Related to CardDAV internals labels Nov 16, 2024
@solracsf solracsf changed the title Fix bug nextcloud/server#46100 fix(job): Check if carddata is resource and read it to string Nov 16, 2024
@ChristophWurst ChristophWurst requested review from st3iny and removed request for miaulalala November 18, 2024 07:56
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much

Co-authored-by: Christoph Wurst <[email protected]>
Signed-off-by: Mikhail Kotelnikov <[email protected]>
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash your commits into one, then we are ready for shipping :shipit:

@joshtrichards
Copy link
Member

/backport to stable30

@joshtrichards
Copy link
Member

/backport to stable29

@joshtrichards
Copy link
Member

/backport to stable28

@solracsf
Copy link
Member

Please squash your commits into one, then we are ready for shipping :shipit:

And commit as fix(job): Check if carddata is resource and read it to string :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request bug feature: carddav Related to CardDAV internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error while running background job OCA\\DAV\\Migration\\BuildSocialSearchIndexBackgroundJob
5 participants