feat: add confirmation dialog for file extension changes #49308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
force-pushed
the
feat/46528/ask-confirm-extension-change
branch
from
04da216
to
9502ffd
Compare
skjnldsv
reviewed
Nov 15, 2024
skjnldsv
reviewed
Nov 15, 2024
It is not destructive (you can revert it) and initialized by the user so as a user I would expect my initiated action to be the primary one. |
susnux
reviewed
Nov 15, 2024
It's not destructive for everyone, but for many users that are not very literate it could still be "sort of" destructive if they don't manage to revert it. So I think we should copy macos in this. People who really know what they're doing will follow through the action anyway. 
|
nfebe
force-pushed
the
feat/46528/ask-confirm-extension-change
branch
2 times, most recently
from
fe99148
to
d706aee
Compare
nfebe
commented
Nov 18, 2024
nfebe
commented
Nov 18, 2024
- Introduced a dialog to confirm if users want to proceed with changing the file extension. - Added handling for dialog visibility to prevent recursion. (Since it looks like use must press escape to stop rename???) Signed-off-by: nfebe <[email protected]>
nfebe
force-pushed
the
feat/46528/ask-confirm-extension-change
branch
from
d706aee
to
a8a934f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves : #46528
Screenshot
Checklist