Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(files): Provide useFileListWidth composable #49305

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Nov 15, 2024

Summary

Replace the mixin with a composable, this is better typed and works in both: Options- and Composition API.
Also added component tests for it.

Checklist

@susnux susnux added 3. to review Waiting for reviews feature: files ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Nov 15, 2024
@susnux susnux added this to the Nextcloud 31 milestone Nov 15, 2024
@susnux susnux force-pushed the refactor/files-filelist-width branch from 2c81114 to 7169dd6 Compare November 15, 2024 11:41
@susnux susnux requested a review from ShGKme November 16, 2024 21:41
@susnux susnux force-pushed the refactor/files-filelist-width branch from 7169dd6 to 9e60d54 Compare November 16, 2024 21:42
Replace the mixin with a composable, this is better typed and works in
both: Options- and Composition API.
Also added component tests for it.

Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux force-pushed the refactor/files-filelist-width branch from 9e60d54 to 5582fcb Compare November 17, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews feature: files ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants