Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(systemtags): enhance create tag in tag picker UX #49129

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 7, 2024

Fix #49026
Better with nextcloud-libraries/nextcloud-vue#6197 (but not a blocker)

image

@skjnldsv skjnldsv added this to the Nextcloud 31 milestone Nov 7, 2024
@skjnldsv skjnldsv requested review from marcoambrosini and a team November 7, 2024 14:33
@skjnldsv skjnldsv self-assigned this Nov 7, 2024
@skjnldsv skjnldsv requested review from susnux, Pytal and szaimen and removed request for a team November 7, 2024 14:33
@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Nov 8, 2024
Copy link
Member

@marcoambrosini marcoambrosini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, what do you think about making it full width?

@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 8, 2024

what do you think about making it full width?

In my todo, when i'll schedule a full review with the design team :)

@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 14, 2024

Will fix cypress test
EDIT: just need a compile and we're good

@skjnldsv skjnldsv force-pushed the feat/systemtags-bulk-create-list branch from 51a2dff to 99a7346 Compare November 15, 2024 10:10
Signed-off-by: skjnldsv <[email protected]>
@skjnldsv skjnldsv merged commit 1436075 into master Nov 15, 2024
118 checks passed
@skjnldsv skjnldsv deleted the feat/systemtags-bulk-create-list branch November 15, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. feature: files feature: tags
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put create tag button into list in systemtag picker
3 participants