Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps-store): Remove apps from force-enabled state when uninstalled #48855

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Oct 23, 2024

Summary

If an app is force-enabled and then uninstalled the force-enabled state was kept. This is now removed, so when the app should be re-installed the compatibility should be reevaluated.

Checklist

@susnux susnux added this to the Nextcloud 31 milestone Oct 23, 2024
@susnux susnux requested review from a team, icewind1991, nfebe, sorbaugh and artonge and removed request for a team October 23, 2024 11:41
@susnux susnux force-pushed the fix/app-store-remove-force-enable branch from d7fcbc2 to cb45a3b Compare October 23, 2024 13:27
@susnux susnux requested review from provokateurin and come-nc and removed request for icewind1991 and sorbaugh October 23, 2024 15:42
@susnux susnux force-pushed the fix/app-store-remove-force-enable branch from cb45a3b to 430bdc7 Compare October 29, 2024 12:44
@susnux susnux force-pushed the fix/app-store-remove-force-enable branch from 430bdc7 to 64bd769 Compare November 11, 2024 20:15
@susnux susnux requested a review from come-nc November 11, 2024 20:15
@susnux susnux force-pushed the fix/app-store-remove-force-enable branch 2 times, most recently from f185c67 to 1cf2bbc Compare November 11, 2024 20:52
@susnux susnux requested a review from come-nc November 18, 2024 10:01
@susnux susnux force-pushed the fix/app-store-remove-force-enable branch from c2d6545 to 923f1cc Compare November 18, 2024 10:02
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean 👍

If an app is force-enabled and then uninstalled the force-enabled state was kept.
This is now removed, so when the app should be re-installed the compatibility should be reevaluated.

Co-authored-by: Ferdinand Thiessen <[email protected]>
Co-authored-by: Côme Chilliet <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux
Copy link
Contributor Author

susnux commented Nov 18, 2024

Adjusted the test ✔️

@susnux susnux force-pushed the fix/app-store-remove-force-enable branch from 923f1cc to 9e327a5 Compare November 18, 2024 13:10
@susnux susnux merged commit e5932c0 into master Nov 18, 2024
185 checks passed
@susnux susnux deleted the fix/app-store-remove-force-enable branch November 18, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants