-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files): Do not jump to top when fileId is set to currentFolder #48632
Conversation
/backport to stable29 |
/backport to stable30 |
Seems like bandage (but ok for a quick fix I would say) I think the underlying issue is we have two properties for three states: States:
(3 is needed because of virtual scrolling to preserve the correct files in view). Properties that control the states:
So I think the best solution would be to add a new query part: So we end up with:
This would allow to reload the page at any state and the same view will be created as before the reload. What do you think @skjnldsv @artonge ? |
Maybe, but quick fix is enough 🙈. |
Fix #48545 Signed-off-by: Louis Chemineau <[email protected]>
Rebased |
c79368f
to
7b27d05
Compare
Fix #48545