Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(caldav): add missing handlers #48508

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Oct 1, 2024

  • Resolves: #

Summary

TODO

  • ...

Checklist

@miaulalala miaulalala added the 3. to review Waiting for reviews label Oct 1, 2024
@miaulalala miaulalala self-assigned this Oct 1, 2024
@miaulalala
Copy link
Contributor Author

/backport to stable30

@miaulalala miaulalala force-pushed the fix/webcal-subscription-jobs-middleware branch from b360fbb to 836a0c2 Compare October 1, 2024 20:04
@miaulalala miaulalala force-pushed the fix/webcal-subscription-jobs-middleware branch from 836a0c2 to d30c066 Compare October 1, 2024 20:12
@miaulalala miaulalala requested review from a team, icewind1991, artonge and nfebe and removed request for a team October 1, 2024 20:42
@miaulalala miaulalala added the feature: caldav Related to CalDAV internals label Oct 1, 2024
Comment on lines -66 to -67
'allow_redirects' => [
'redirects' => 10
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer accepts redirects?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redirects should still work as they are enabled by default with a maximum of 5 redirects.

Resolving the final location does not work without a middleware, and therefore we are skipping it for now.

@miaulalala miaulalala merged commit 004d7da into master Oct 2, 2024
178 checks passed
@miaulalala miaulalala deleted the fix/webcal-subscription-jobs-middleware branch October 2, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews feature: caldav Related to CalDAV internals
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

4 participants