Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smaller input field for update notification groups #4828

Closed
wants to merge 1 commit into from

Conversation

MorrisJobke
Copy link
Member

Fixes a paper cut from #2672 - cc @nextcloud/designers

Before:

bildschirmfoto 2017-05-11 um 19 32 02

After:

bildschirmfoto 2017-05-11 um 19 31 38

@MorrisJobke MorrisJobke added 3. to review Waiting for reviews design Design, UI, UX, etc. papercut Annoying recurring issue with possibly simple fix. labels May 12, 2017
@MorrisJobke MorrisJobke added this to the Nextcloud 12.0 milestone May 12, 2017
@mention-bot
Copy link

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @LukasReschke and @blizzz to be potential reviewers.

@nickvergessen nickvergessen mentioned this pull request May 12, 2017
59 tasks
@nickvergessen
Copy link
Member

Well I don't care too much, I just made it longer, because the space is there and otherwise the height increases:

administration_-nextcloud-_2017-05-12_09 52 47

@LukasReschke
Copy link
Member

I'd say let's keep the @nickvergessen approach then? 😃

@MorrisJobke MorrisJobke deleted the smaller-update-groups branch May 12, 2017 15:21
@jancborchardt
Copy link
Member

Sorry for the late reply:
In most cases it will likely stay only the administrators. So that case should look good, as it does now. If we want to improve it then ideally it is through dynamic width increase until it needs to wrap cause of the viewport ending. That probably involves some JS which is not really necessary there, so maybe it’s best to leave it like it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants