Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): Fix provisioning enabled apps #47596

Merged
merged 1 commit into from
Aug 29, 2024
Merged

fix(test): Fix provisioning enabled apps #47596

merged 1 commit into from
Aug 29, 2024

Conversation

provokateurin
Copy link
Member

@provokateurin provokateurin commented Aug 29, 2024 •
edited
Loading

Summary

#47532 added the app, but didn't adjust the tests. They didn't even run, because the files were not changed.
Example failure: https://github.com/nextcloud/server/actions/runs/10610490820/job/29408077638

Checklist

@provokateurin provokateurin added bug 3. to review Waiting for reviews labels Aug 29, 2024
@provokateurin provokateurin added this to the Nextcloud 31 milestone Aug 29, 2024
@provokateurin provokateurin requested a review from a team August 29, 2024 07:32
@provokateurin
Copy link
Member Author

/backport! to stable30

@provokateurin provokateurin mentioned this pull request Aug 29, 2024
Merged
@backportbot backportbot bot mentioned this pull request Aug 29, 2024
Merged
@nextcloud nextcloud deleted a comment from provokateurin Aug 29, 2024
@provokateurin provokateurin force-pushed the fix/test/provisioning-enabled-apps branch from cc6ac78 to 1b10337 Compare August 29, 2024 07:40
@provokateurin provokateurin force-pushed the fix/test/provisioning-enabled-apps branch from 1b10337 to 54e6103 Compare August 29, 2024 07:43
@provokateurin provokateurin added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 29, 2024
@nickvergessen nickvergessen merged commit 6cfa388 into master Aug 29, 2024
175 of 176 checks passed
@nickvergessen nickvergessen deleted the fix/test/provisioning-enabled-apps branch August 29, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@szaimen szaimen szaimen approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
5 participants
@provokateurin @nickvergessen @juliusknorr @szaimen @come-nc