[stable29] fix: Correctly load favorites for subpath #47501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
nfebe,
Pytal and
sorbaugh
and removed request for
a team
susnux
changed the title
susnux
force-pushed
the
fix/files-favorites
branch
from
7425f80
to
f91c2e6
Compare
skjnldsv
approved these changes
Aug 27, 2024
AndyScherzinger
approved these changes
Aug 27, 2024
susnux
force-pushed
the
fix/files-favorites
branch
from
f91c2e6
to
1be3aac
Compare
…ions and make it cancelable Also this fixes the view being writeable Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/files-favorites
branch
from
1be3aac
to
e7130c8
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Partly backport the refactoring to use
@nextcloud/filesfunctions as this fixes the favorites view issue.Checklist