fix(files): Don't try to use missing cache entries #46840
Conversation
solracsf
requested review from
a team,
ArtificialOwl,
Altahrim and
yemkareems
and removed request for
a team
The `Cache::get()` function can return `ICacheEntry` or `false`. Added check ensures that `false` return value is not used as an array. This silences: `Trying to access array offset on value of type bool` errors. Signed-off-by: Jacek Tomasiak <[email protected]>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Summary
The
Cache::get()function can returnICacheEntryorfalse. Added check ensures thatfalsereturn value is not used as an array. This silences:Trying to access array offset on value of type boolerrors.