Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ShareSettings): Proper wording for share autocompletion settings #46830

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented Jul 28, 2024

The existing text is incorrect and can be misleading as seen in : #42501

@nfebe
Copy link
Contributor Author

nfebe commented Jul 28, 2024

/backport to stable30

@nfebe
Copy link
Contributor Author

nfebe commented Jul 28, 2024

/backport to stable29

@nfebe
Copy link
Contributor Author

nfebe commented Jul 28, 2024

/backport to stable28

@nfebe
Copy link
Contributor Author

nfebe commented Jul 29, 2024

/compile

The existing is incorrect and can be misleading as seen in : #42501

Signed-off-by: fenn-cs <[email protected]>
@nfebe nfebe force-pushed the chore/42501/enhance-automcompletion-setting-text branch from a27199b to ca8fc8d Compare July 30, 2024 17:57
@nfebe
Copy link
Contributor Author

nfebe commented Jul 30, 2024

/compile

@nfebe nfebe enabled auto-merge July 30, 2024 17:58
Signed-off-by: nextcloud-command <[email protected]>
@nfebe nfebe merged commit 17ff269 into master Jul 30, 2024
111 checks passed
@nfebe nfebe deleted the chore/42501/enhance-automcompletion-setting-text branch July 30, 2024 18:19
Copy link

backportbot bot commented Jul 30, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/46830/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick ca8fc8d2 4ee37013

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/46830/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

backportbot bot commented Jul 30, 2024

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/46830/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick ca8fc8d2 4ee37013

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/46830/stable29

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

backportbot bot commented Jul 30, 2024

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/46830/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick ca8fc8d2 4ee37013

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/46830/stable30

Error: Failed to clone repository: Failed to checkout branches: error: pathspec 'stable30' did not match any file(s) known to git


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@nfebe nfebe linked an issue Jul 30, 2024 that may be closed by this pull request
8 tasks
nfebe added a commit that referenced this pull request Jul 31, 2024
[stable29]  chore(ShareSettings): Proper wording for share autocompletion settings #46830
Copy link
Contributor

github-actions bot commented Nov 2, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Restrict users to only share with users in their groups does not work
4 participants