Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files_sharing): add missing subtitle on search for share recipients #46591

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

luka-nextcloud
Copy link
Contributor

Summary

TODO

  • ...

Checklist

@luka-nextcloud luka-nextcloud added bug 3. to review Waiting for reviews labels Jul 17, 2024
@luka-nextcloud luka-nextcloud self-assigned this Jul 17, 2024
Copy link
Member

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should rename the subtitle key in options to subname instead of reimplementing the option slot

@luka-nextcloud
Copy link
Contributor Author

We should rename the subtitle key in options to subname instead of reimplementing the option slot

Changing subtitle to subname does not work. It is because subname is only visible on avatar size of 32 and above (https://nextcloud-vue-components.netlify.app/#/Components/NcListItems?id=nclistitemicon)

@Pytal
Copy link
Member

Pytal commented Jul 22, 2024

Changing subtitle to subname does not work. It is because subname is only visible on avatar size of 32 and above (nextcloud-vue-components.netlify.app)

I see, in that case it is a bug in the lib so we should be increase it there to 32px + do the subname rename here

@luka-nextcloud
Copy link
Contributor Author

Changing subtitle to subname does not work. It is because subname is only visible on avatar size of 32 and above (nextcloud-vue-components.netlify.app)

I see, in that case it is a bug in the lib so we should be increase it there to 32px + do the subname rename here

I made a PR on the lib side. We first need to check and release it.

@luka-nextcloud
Copy link
Contributor Author

@juliushaertl Should we wait until the new version of the library is released?

@luka-nextcloud luka-nextcloud force-pushed the fix/subtitle-on-search-for-share branch from 7d2a763 to 3fea28d Compare July 31, 2024 08:21
@luka-nextcloud luka-nextcloud force-pushed the fix/subtitle-on-search-for-share branch from 3fea28d to 3c6ba1d Compare July 31, 2024 14:09
@juliusknorr
Copy link
Member

/compile amend /

@AndyScherzinger AndyScherzinger added this to the Nextcloud 30 milestone Aug 1, 2024
@blizzz blizzz mentioned this pull request Aug 1, 2024
@luka-nextcloud luka-nextcloud force-pushed the fix/subtitle-on-search-for-share branch 3 times, most recently from 422667a to 01ee3e5 Compare August 1, 2024 15:07
@juliusknorr
Copy link
Member

@luka-nextcloud maybe try to push the commit just with the src change and use the compile command if you can't get the local build to pass ci

@luka-nextcloud luka-nextcloud force-pushed the fix/subtitle-on-search-for-share branch from 01ee3e5 to 16b182b Compare August 1, 2024 18:20
@luka-nextcloud
Copy link
Contributor Author

/compile amend /

@juliusknorr juliusknorr merged commit 06b149c into master Aug 1, 2024
109 of 111 checks passed
@juliusknorr juliusknorr deleted the fix/subtitle-on-search-for-share branch August 1, 2024 20:29
@AndyScherzinger
Copy link
Member

Since this is reported broken for v28+, can this be backported then @juliushaertl @luka-nextcloud ? Can't tell since it mentioned a lib change, so slightly more complex to do eventually.

@juliusknorr
Copy link
Member

Yes, I'd leave that to @luka-nextcloud for the case he has ;)

@luka-nextcloud
Copy link
Contributor Author

/backport to stable28

Copy link

backportbot bot commented Aug 2, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/46591/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick a3711016

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/46591/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Remote server name missing from search result in sharing tab
4 participants