-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files_sharing): add missing subtitle on search for share recipients #46591
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should rename the subtitle key in options
to subname instead of reimplementing the option slot
Changing subtitle to subname does not work. It is because subname is only visible on avatar size of 32 and above (https://nextcloud-vue-components.netlify.app/#/Components/NcListItems?id=nclistitemicon) |
I see, in that case it is a bug in the lib so we should be increase it there to 32px + do the subname rename here |
46a645f
to
7d2a763
Compare
I made a PR on the lib side. We first need to check and release it. |
@juliushaertl Should we wait until the new version of the library is released? |
7d2a763
to
3fea28d
Compare
3fea28d
to
3c6ba1d
Compare
/compile amend / |
3c6ba1d
to
41c0fd0
Compare
422667a
to
01ee3e5
Compare
@luka-nextcloud maybe try to push the commit just with the src change and use the compile command if you can't get the local build to pass ci |
01ee3e5
to
16b182b
Compare
/compile amend / |
Signed-off-by: Luka Trovic <[email protected]> Signed-off-by: nextcloud-command <[email protected]>
16b182b
to
a371101
Compare
Since this is reported broken for v28+, can this be backported then @juliushaertl @luka-nextcloud ? Can't tell since it mentioned a lib change, so slightly more complex to do eventually. |
Yes, I'd leave that to @luka-nextcloud for the case he has ;) |
/backport to stable28 |
The backport to # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b backport/46591/stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick a3711016
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/46591/stable28 Error: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Summary
TODO
Checklist