Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): Add missing handling for envCache in getKeys() #46140

Merged
merged 4 commits into from
Sep 16, 2024

Commits on Jul 8, 2024

  1. fix(config): Add missing handling for envCache in getKeys()

    NC_ env variable overrides were not appearing in
    the output of `occ config:list system` nor `occ
    config:system:get xxx`. This was creating nearly
    impossible to diagnose configuration/ behavior
    disprepancies.
    
    - Refactored readData() so that we aren't saving
      the entire environment in the envCache anymore
      (only those prefixed "NC_") and so that we save
      NC_ provided config values under their real
      key.
    - Refactored getValue() to accommodate readData()
      refactor
    - Fixed getKeys() to properly return
      envCache keys too
    
    Environment provided config variables now appear
    in `occ config:list system` as expected.
    
    Environment provided config variables now appear
    when queried via `occ config:system:get KEY`
    
    envCache is now free of non-NC stuff.
    
    Signed-off-by: Josh Richards <[email protected]>
    joshtrichards committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    62192ca View commit details
    Browse the repository at this point in the history
  2. fix(config): add envCache tests for getKeys()

    Signed-off-by: Josh Richards <[email protected]>
    joshtrichards committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    2ffff51 View commit details
    Browse the repository at this point in the history
  3. fix: switch from explode to substr (faster)

    Signed-off-by: Josh Richards <[email protected]>
    joshtrichards committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    34a9e48 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. Merge branch 'master' into fix-nc-env-inclusion

    Signed-off-by: Robin Appelman <[email protected]>
    icewind1991 authored Sep 16, 2024
    Configuration menu
    Copy the full SHA
    13088b7 View commit details
    Browse the repository at this point in the history