Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(UnifiedSearch): Restore ctrl+f activates unified search #46120

Closed
wants to merge 2 commits into from

Conversation

nfebe
Copy link
Contributor

@nfebe nfebe commented Jun 25, 2024

Summary

CTRL+F is a common search shortcut and should activate Unified Search on Nextcloud.

Resolves : #44160

@nfebe nfebe added 3. to review Waiting for reviews feature: search labels Jun 25, 2024
@nfebe nfebe added this to the Nextcloud 30 milestone Jun 25, 2024
@nfebe nfebe self-assigned this Jun 25, 2024
@nfebe nfebe force-pushed the fix/44160/ctrl-f-trigger-global-search branch from 2e56025 to 670afc4 Compare June 26, 2024 10:34
`CTRL+F` is a common search shortcut and should activate Unified Search on Nextcloud.

Resolves : #44160

Signed-off-by: fenn-cs <[email protected]>
@nfebe nfebe force-pushed the fix/44160/ctrl-f-trigger-global-search branch from 670afc4 to 7f15ad8 Compare June 26, 2024 10:45
@nfebe nfebe requested a review from susnux June 26, 2024 10:46
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@nfebe nfebe enabled auto-merge June 27, 2024 18:40
@nfebe nfebe force-pushed the fix/44160/ctrl-f-trigger-global-search branch 2 times, most recently from 5c9e675 to 7f15ad8 Compare June 27, 2024 19:14
@nfebe
Copy link
Contributor Author

nfebe commented Jun 27, 2024

Effort duplicated and merged in : #41609

@nfebe nfebe closed this Jun 27, 2024
auto-merge was automatically disabled June 27, 2024 19:38

Pull request was closed

@skjnldsv skjnldsv removed this from the Nextcloud 30 milestone Aug 14, 2024
@ChristophWurst ChristophWurst deleted the fix/44160/ctrl-f-trigger-global-search branch September 2, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

[Bug]: Using ctrl+f to activate search in nextcloud stopped working after update to 28.
4 participants