refactor: don't join on filecache in defaultshareprovider #45456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
ArtificialOwl,
yemkareems and
sorbaugh
and removed request for
a team
icewind1991
force-pushed
the
def-share-provider-filecache-joins
branch
from
5d0ab68
to
3a31211
Compare
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
def-share-provider-filecache-joins
branch
from
3a31211
to
1e25872
Compare
icewind1991
added
2. developing
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Joining on the filecache is not compatible with the upcoming sharding