Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): Update authtoken activity selectively #45411

Merged
merged 1 commit into from
May 29, 2024

Conversation

ChristophWurst
Copy link
Member

Summary

We want to update the authtoken.last_activity when we write authtoken.last_check. But we don't want the activity to update for updates of any other fields, when the token is not used.

How to test

  1. Create an auth token via the personal security settings
  2. Open the authtoken database table, set last_activity=0 for the latest row
  3. Change the name of the auth token

master: last activity changes to now
here: last activity stays at 54 years ago

Checklist

@kesselb kesselb merged commit fca38e1 into master May 29, 2024
155 checks passed
@kesselb kesselb deleted the fix/auth/selective-token-activity-update branch May 29, 2024 10:05
@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
Development

Successfully merging this pull request may close these issues.

3 participants