Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(files): Allow to upload folders #45095

Merged
merged 2 commits into from
Jun 24, 2024
Merged

feat(files): Allow to upload folders #45095

merged 2 commits into from
Jun 24, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Apr 29, 2024

Summary

Add support for uploading folders using the "new" menu.

Checklist

@susnux susnux force-pushed the feat/upload-folders branch 3 times, most recently from 36b5ec4 to 910301f Compare June 17, 2024 14:47
@susnux susnux changed the title [WIP] feat(files): Allow to upload folders feat(files): Allow to upload folders Jun 17, 2024
@susnux susnux added 3. to review Waiting for reviews feature: files and removed 2. developing Work in progress labels Jun 17, 2024
@susnux susnux requested a review from skjnldsv June 17, 2024 14:47
class="files-list__header-upload-button"
:content="getContent"
:destination="currentFolder"
:forbidden-characters="forbiddenCharacters"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be built in the lib?
In Photos we are using the uploader, it would be nice to have this by default

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the forbidden-characters can be replaced by nextcloud-files version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can do so in a new uploader version :)

Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@solracsf solracsf added this to the Nextcloud 30 milestone Jun 18, 2024
@susnux susnux force-pushed the feat/upload-folders branch 4 times, most recently from 2c162ce to be6a1f4 Compare June 23, 2024 16:18
@susnux susnux force-pushed the feat/upload-folders branch 2 times, most recently from 079fd2d to 0a714ca Compare June 24, 2024 17:50
Signed-off-by: Ferdinand Thiessen <[email protected]>
@susnux susnux merged commit 3e64ad7 into master Jun 24, 2024
110 checks passed
@susnux susnux deleted the feat/upload-folders branch June 24, 2024 19:53
@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upload folder menu option
5 participants