Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CalDAV): remove UNKNOWN from room / resource consideration #44938

Merged
merged 1 commit into from
Apr 26, 2024

Conversation

miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Apr 19, 2024

Summary

The UNKNOWN CU type might be given to legitimate ATTENDEEs of an event.

Filtering only for specific CU types will allow for actual attendees to still receive invitations. There is nothing in the RFC that specifies that UNKNOWN is a "thing".

Checklist

@miaulalala miaulalala added the 3. to review Waiting for reviews label Apr 19, 2024
@miaulalala miaulalala added this to the Nextcloud 30 milestone Apr 19, 2024
@miaulalala miaulalala self-assigned this Apr 19, 2024
@miaulalala
Copy link
Contributor Author

/backport to stable29

@miaulalala
Copy link
Contributor Author

/backport to stable28

@miaulalala
Copy link
Contributor Author

/backport to stable27

Copy link
Member

@tcitworld tcitworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miaulalala
Copy link
Contributor Author

What about nextcloud/calendar#5706 (comment) ?

We could, but nobody has complained about the email notifications (yet) so I'm hesitant to touch it.

@miaulalala miaulalala requested review from a team, ArtificialOwl, yemkareems and sorbaugh and removed request for a team April 25, 2024 17:41
@miaulalala miaulalala merged commit 10af087 into master Apr 26, 2024
157 checks passed
@miaulalala miaulalala deleted the fix/remove-unknown-from-imip-service branch April 26, 2024 11:16
@miaulalala
Copy link
Contributor Author

/backport to stable29

@miaulalala
Copy link
Contributor Author

/backport to stable28

@miaulalala
Copy link
Contributor Author

/backport to stable27

Copy link

backportbot bot commented Apr 26, 2024

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b backport/44938/stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick a28f2647

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/44938/stable27

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/44938/stable27."}


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

backportbot bot commented Apr 26, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/44938/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick a28f2647

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/44938/stable28

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/44938/stable28."}


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
Development

Successfully merging this pull request may close these issues.

New and updated appointments are not sent via e-mail
3 participants