Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): Update doctrine/dbal to 3.8.3 #44683

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Apr 5, 2024

Summary

We can not upgrade to v4 because we still support some older MariaDB version that got dropped there (10.3 / 10.4 and Oracle <= 12).
But we can upgrade to 3.8 as this is the current version that gets updates (3.7 is EOL).

Checklist

@susnux susnux added this to the Nextcloud 30 milestone Apr 5, 2024
@susnux susnux added the 3. to review Waiting for reviews label Apr 5, 2024
@susnux susnux marked this pull request as ready for review April 5, 2024 14:03
@susnux
Copy link
Contributor Author

susnux commented Apr 5, 2024

Not sure if we also want this for 29 or stay with EOL 3.7 on 29, but CI looks good :)

@susnux susnux force-pushed the fix/update-doctrine-dbal-3_8_3 branch 2 times, most recently from 8e2b18d to cb7e52d Compare April 5, 2024 15:03
@susnux
Copy link
Contributor Author

susnux commented Apr 5, 2024

Updated 3rdparty to merge commit ✅

@nickvergessen nickvergessen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 5, 2024
@susnux susnux force-pushed the fix/update-doctrine-dbal-3_8_3 branch from cb7e52d to 7498b49 Compare April 5, 2024 15:19
@come-nc come-nc force-pushed the fix/update-doctrine-dbal-3_8_3 branch from 7498b49 to d6c531c Compare April 8, 2024 07:49
@nickvergessen nickvergessen merged commit 4299c37 into master Apr 8, 2024
171 checks passed
@nickvergessen nickvergessen deleted the fix/update-doctrine-dbal-3_8_3 branch April 8, 2024 09:07
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish dependencies feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants