Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(contactsinteraction): Allow vCard download #44457

Merged
merged 1 commit into from
Mar 26, 2024
Merged

fix(contactsinteraction): Allow vCard download #44457

merged 1 commit into from
Mar 26, 2024

Conversation

ChristophWurst
Copy link
Member

Summary

Sabre calculates a header for the size of a vcard, therefore we have to implement the size method.

How to test

  1. Share a file to an email address
  2. Open Contacts and find a generated contact for the email address
  3. Open the contact details
  4. Click on the actions menu in the top right
  5. Click Download

Master: nothing happens (URL is opened in a new tab and kind of silently fails).
Here: vcard is downloaded.

Checklist

@ChristophWurst ChristophWurst added this to the Nextcloud 29 milestone Mar 25, 2024
@ChristophWurst ChristophWurst self-assigned this Mar 25, 2024
miaulalala
miaulalala approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maxence

@Altahrim Altahrim mentioned this pull request Mar 26, 2024
Merged
@ChristophWurst ChristophWurst force-pushed the fix/contactsinteraction/download-vcard branch from a74f440 to e80fc99 Compare March 26, 2024 12:59
@ChristophWurst
fix(contactsinteraction): Allow vCard download
b8250af 
Sabre calculates a header for the size of a vcard, therefore we have to
implement the size method.

Signed-off-by: Christoph Wurst <[email protected]>
@ChristophWurst ChristophWurst force-pushed the fix/contactsinteraction/download-vcard branch from e80fc99 to b8250af Compare March 26, 2024 13:41
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 26, 2024
@Altahrim Altahrim merged commit 5a6e6a1 into master Mar 26, 2024
167 checks passed
@Altahrim Altahrim deleted the fix/contactsinteraction/download-vcard branch March 26, 2024 19:18
@Altahrim Altahrim removed the 4. to release Ready to be released and/or waiting for tests to finish label Mar 26, 2024
@ChristophWurst
Copy link
Member Author

/backport to stable28

@ChristophWurst
Copy link
Member Author

/backport to stable27

@ChristophWurst
Copy link
Member Author

/backport to stable26

@ChristophWurst
Copy link
Member Author

/backport to stable28

@backportbot backportbot bot mentioned this pull request May 13, 2024
Merged
@ChristophWurst
Copy link
Member Author

/backport to stable27

@backportbot backportbot bot mentioned this pull request May 22, 2024
Merged
@backportbot backportbot bot mentioned this pull request May 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miaulalala miaulalala miaulalala approved these changes

@Altahrim Altahrim Altahrim approved these changes

@hamza221 hamza221 Awaiting requested review from hamza221

@GVodyanov GVodyanov Awaiting requested review from GVodyanov

Assignees

@ChristophWurst ChristophWurst

Labels
bug feature: carddav Related to CardDAV internals feature: contacts feature: dav
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristophWurst @Altahrim @miaulalala