Check permissions of all accessible file for versions #44362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
added
enhancement
3. to review
artonge
force-pushed
the
artonge/feat/support_migrating_versions_across_storages
branch
from
3bed871
to
975ef17
Compare
artonge
changed the base branch from
artonge/feat/support_migrating_versions_across_storages
to
master
artonge
force-pushed
the
artonge/feat/check_permissions_of_all_nodes_for_versions
branch
2 times, most recently
from
9628bb1
to
7442ca3
Compare
icewind1991
approved these changes
Mar 20, 2024
Merged
artonge
force-pushed
the
artonge/feat/check_permissions_of_all_nodes_for_versions
branch
from
7442ca3
to
865bcb2
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| $sourceFile = array_pop($nodes); | ||
| if (!$sourceFile) { | ||
| throw new NotFoundException("Version file not accessible by current user"); | ||
| $nodes = $this->rootFolder->getUserFolder($currentUserId)->getById($sourceFile->getId()); |
Check notice
Code scanning / Psalm
PossiblyNullArgument Note
come-nc
approved these changes
Mar 21, 2024
…files Forbid tagging readonly files Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/feat/check_permissions_of_all_nodes_for_versions
branch
from
865bcb2
to
a15c0d6
Compare
artonge
deleted the
artonge/feat/check_permissions_of_all_nodes_for_versions
branch
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.