Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use classmap to load core files #435

Merged
merged 1 commit into from
Jul 18, 2016
Merged

Use classmap to load core files #435

merged 1 commit into from
Jul 18, 2016

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Jul 18, 2016

We can't use an authoritive classmap in the current state as it would
kill app loading. However we can use a proper classmap for the normal
core stuff.

Performance: https://blackfire.io/profiles/compare/69212b7f-3227-421d-8aff-9b87bd166bba/graph

It can probabaly be even better on a production system. Since that I/O time is just bogus

CC: @LukasReschke @nickvergessen @MorrisJobke @icewind1991

We can't use an authoritive classmap in the current state as it would
kill app loading. However we can use a proper classmap for the normal
core stuff.
@rullzer rullzer added the 3. to review Waiting for reviews label Jul 18, 2016
@rullzer rullzer added this to the Nextcloud Next milestone Jul 18, 2016
@mention-bot
Copy link

@rullzer, thanks for your PR! By analyzing the annotation information on this pull request, we identified @LukasReschke to be a potential reviewer

@nickvergessen
Copy link
Member

When do we need to update this? only on release, or also while adding a new class?

@rullzer
Copy link
Member Author

rullzer commented Jul 18, 2016

When adding new files.
Note that since we did not make it authoriative it still uses the normal PSR-4 loading when loading classes not in the classmap. So worst case it is a little slower.

@icewind1991
Copy link
Member

👍

@MorrisJobke
Copy link
Member

Tested and still works 👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 18, 2016
@rullzer
Copy link
Member Author

rullzer commented Jul 18, 2016

Drone finished succesfully (see https://drone.weasel.rocks/nextcloud/server/470) but for some reason didn't update github.

Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants