-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(files) : Give a hint that names starting with dots might be hidden #43366
base: master
Are you sure you want to change the base?
feature(files) : Give a hint that names starting with dots might be hidden #43366
Conversation
This might annoy a lot of users because it is shown everytime you rename such a file, especially if you know what you are doing. So cc @jancborchardt for UX |
As an alternative we could use something like a tooltip. It warns but doesn't get into your way. What do you think? |
Yup, would agree with @ChristophWurst’s suggestion of a tooltip. Does this work @arublov @susnux? |
Apparently the dialogue for new files now looks like this: This could be enhanced by a https://nextcloud-vue-components.netlify.app/#/Components/NcNoteCard with type warning right under/over the filename input. |
Yes, I already tried to implement with NcNoteCard, but if you want to rename a folder/file, it happens: |
…ames starting with dots might be hidden nextcloud#21609 Signed-off-by: Andrii Rublov <[email protected]>
35e5341
to
43212e8
Compare
@ChristophWurst / @jancborchardt , If I do like this for renaming folders/files? The NcNoteCard will appear to the right of the input. |
About renaming warning: I think the dialog is the way to go, we just need a never show this again checkbox. This type of warning doesn't work well in a tooltip, and for most users it's actually good to break the flow be very clear about the fact that the file/folder is about to be hidden. |
Checklist
Before:
The file name is changed with dots at the beginning without confirmation.
After:
Now when changing a file name with a dot/s at the beginning, a confirmation will pop up first to warn the user that the file can be hidden if the name is changed.