[Copy] New core setting : shareapi_only_share_with_group_members_exclude_gro… #43186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
added
enhancement
3. to review
artonge
added
4. to release
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -63,6 +63,7 @@ | |||
| $excludedGroups = $this->config->getAppValue('core', 'shareapi_exclude_groups_list', ''); | |||
| $linksExcludedGroups = $this->config->getAppValue('core', 'shareapi_allow_links_exclude_groups', ''); | |||
| $excludedPasswordGroups = $this->config->getAppValue('core', 'shareapi_enforce_links_password_excluded_groups', ''); | |||
| $onlyShareWithGroupMembersExcludeGroupList = $this->config->getAppValue('core', 'shareapi_only_share_with_group_members_exclude_group_list', ''); | |||
Check notice
Code scanning / Psalm
DeprecatedMethod Note
come-nc
approved these changes
Jan 29, 2024
|
susnux
approved these changes
Jan 29, 2024
Signed-off-by: Baptiste Fotia <[email protected]>
Signed-off-by: Baptiste Fotia <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
feature/37677/exclude-some-groups-from-sharing-with-users
branch
from
8d59add
to
bd0092a
Compare
For some CI steps to get executed. But it looks like we just moved them from drone to GH actions this week. It is also easier for us to rebase and edit if the source branch is in our repo. Can you try to rebase your PR ? You will need to add the following changes to make tests greens:
You will also need to compile the front-end code again. We can have a call tomorrow at 16h to do it together to make sure that your PR is merged this week. |
Sure, I'm going to rebase and build our PR in the early afternoon. Thanks 🙂 |
zak39
added a commit
to arawa/server
that referenced
this pull request
Jan 30, 2024
I added our context in the unit tests following the advice of Louis. Link : nextcloud#43186 (comment) Signed-off-by: Baptiste Fotia <[email protected]>
zak39
added a commit
to arawa/server
that referenced
this pull request
Jan 30, 2024
I added our context in the unit tests following the advice of Louis. Link : nextcloud#43186 (comment) Signed-off-by: Baptiste Fotia <[email protected]>
5 tasks
zak39
added a commit
to arawa/server
that referenced
this pull request
Jan 31, 2024
I added our context in the unit tests following the advice of Louis. Link : nextcloud#43186 (comment) Signed-off-by: Baptiste Fotia <[email protected]>
|
Hi, the documentation PR is here : nextcloud/documentation#11537 |
skjnldsv
deleted the
feature/37677/exclude-some-groups-from-sharing-with-users
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy of #38173 to hopefully have it merged.