Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(theming): fix warning of incorrect NcCheckboxRadioSwitch usage #42834

Merged

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jan 16, 2024

Summary

No visual changes.

Removes error:

image

Checklist

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 this was there for too long 👍

Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love this change, especially because of how many lines this will declutter within the console!

Unrelated, but we should definitely fix our style guides problem for displaying this components props. Something I will assign myself for now, but do when we are done with all the accessibility issues :) here

@emoral435 emoral435 force-pushed the chore/theming--remove-warning-of-nc-checkbox-radio-switch-usage branch from 510c5be to 9310dba Compare January 16, 2024 16:17
@ShGKme
Copy link
Contributor Author

ShGKme commented Jan 16, 2024

Unrelated, but we should definitely fix our style guides problem for displaying this components props

@ShGKme ShGKme merged commit 07c0a5f into master Jan 16, 2024
42 checks passed
@ShGKme ShGKme deleted the chore/theming--remove-warning-of-nc-checkbox-radio-switch-usage branch January 16, 2024 20:43
@ShGKme
Copy link
Contributor Author

ShGKme commented Jan 16, 2024

/backport to stable28

@backportbot-nextcloud
Copy link

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b fix/foo-stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@emoral435
Copy link
Contributor

/skjnldsv-backport 9310dba stable28

@skjnldsv
Copy link
Member

/skjnldsv-backport 9310dba to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants