-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unneeded styles: everything is handled by NcVue #42559
Remove unneeded styles: everything is handled by NcVue #42559
Conversation
Signed-off-by: julia.kirschenheuter <[email protected]>
0921b8b
to
024d291
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked this on my dev env and saw that removing this did not cause anything big to stylistically change - it looks good to me.
I do not know if there are any other apps that somehow depend on this, but to my understanding this only lets the elements that are for app navigation within a page have their border color be the primary color. When the changes to the NcAppNavigationItem.scss
gets merged, this will be all good 👍
So, these styles are not supposed to affect So the best could be to fix the selector. but probably these styles are not actual anymore. Need to check if we still have any non-NcAppNavigation navigation. |
I haven't found non-vue navigation anywhere. Should be safe to remove. |
/backport to stable28 |
Summary
Checklist