Backport/42379/fix/aria prop for nc bread crumb component #42486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nextcloud bot <[email protected]>
[stable28] fix(dav): Allow single-day out of office
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: GitHub <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
[stable28] fix(files): Move aria-label for favorite icon from span to icon
Signed-off-by: Nextcloud bot <[email protected]>
[stable28] fix(files_external): Fix "Could not find resource main.js to load"
fixes #39266 Signed-off-by: Marcel Klehr <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
[stable28] fix(security): Handle idn_to_utf8 returning false
Signed-off-by: Joas Schilling <[email protected]>
Signed-off-by: Joas Schilling <[email protected]>
[stable28] fix(metadata): Allow to load metadata of multiple files at once
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
If a TypeError is passed here, it in turn causes a TypeError which kills the rendering of the error page. Signed-off-by: Varun Patil <[email protected]>
- add configuration to specify one LDAP group acting as admin group (CLI) - implement `isAdmin()` method, basically relying on inGroup against the configured group Signed-off-by: Arthur Schiwon <[email protected]>
Signed-off-by: Arthur Schiwon <[email protected]>
Signed-off-by: Arthur Schiwon <[email protected]>
[stable28] Migrate database missing checks
Signed-off-by: Nextcloud bot <[email protected]>
Signed-off-by: Maxence Lange <[email protected]>
For screen readers the table header was very verbose and confusing, as the SR reads out e.g. "sort list by name button FILENAME" for every row / file. Instead reduce it to "name button FILENAME" and add information about sorting to caption, as recommended by WCAG [1] [1]: https://www.w3.org/WAI/ARIA/apg/patterns/table/examples/sortable-table/ Signed-off-by: Ferdinand Thiessen <[email protected]>
On change/input from user which has the effect of filtering, we want to send the query to the API to obtained fresh results, based on the databased on not just preloaded contacts. Signed-off-by: fenn-cs <[email protected]>
As expected, a user does not see themselves in their contact list, however, when using the contact list for filtering search, a user, might want to limit the search to things that pertain to them. Signed-off-by: fenn-cs <[email protected]>
Signed-off-by: fenn-cs <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
[stable28] Backport unified search improvments
Signed-off-by: Eduardo Morales <[email protected]>
emoral435
requested review from
nickvergessen,
provokateurin,
ChristophWurst,
miaulalala,
st3iny,
come-nc,
blizzz,
Pytal,
JuliaKirschenheuter and
tcitworld
as code owners
emoral435
deleted the
backport/42379/fix/ARIA-prop-for-NcBreadCrumb-component
branch
emoral435
restored the
backport/42379/fix/ARIA-prop-for-NcBreadCrumb-component
branch
ChristophWurst
deleted the
backport/42379/fix/ARIA-prop-for-NcBreadCrumb-component
branch
emoral435
removed request for
nickvergessen,
ChristophWurst,
st3iny,
blizzz,
tcitworld,
JuliaKirschenheuter,
miaulalala,
Pytal,
provokateurin and
come-nc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of #42379