-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(comments): Drop dead code from comments app #42174
Conversation
Signed-off-by: Ferdinand Thiessen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What was the use of this script?
Drone (samba) unrelated |
Old API that was dropped long time ago it seems. The only API used by other apps is the |
I remember @nickvergessen was also afraid to lose an API for Talk |
It was not dropped. I prevent removal just last month.... This is public API: server/lib/private/Comments/Manager.php Lines 1615 to 1623 in aa5f037
Can we just keep it for now? We can deprecate and drop in 3 years if there are reasons apart from "just because" |
See #41491 (review) and further |
Reverting in #42207 to restore the nice functionality and public API |
@nickvergessen that is a different script that is still provided. Meaning the public API is still there just some dead files are removed. |
Summary
Drop code that is not used anymore from repository - also drop "comments" script / entry point which is unused.
Checklist