Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable28] Fix some silent share bugs #42076

Merged
merged 3 commits into from
Dec 7, 2023
Merged

[stable28] Fix some silent share bugs #42076

merged 3 commits into from
Dec 7, 2023

Commits on Dec 7, 2023

  1. Create element reference inside $nextTick() 

    Accessing `this.$refs.shareList` outside $nextTick()
 could lead to the holder (`listComponent`) being undefined
 as the ref is yet to exist.

Signed-off-by: fenn-cs <[email protected]>
    @nfebe @AndyScherzinger
    nfebe authored and AndyScherzinger committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    9c67ae4 View commit details
    Browse the repository at this point in the history

  2. Remove newPassword from share model, if disabled 

    It's important to delete the `newPassword` prop from the share
 model, if the user unchecks the isPasswordProtected checkbox.

This clearer and allows for the unchecking to actually work as
`this.$set()` fails with the falsy value `''`.

Signed-off-by: fenn-cs <[email protected]>
    @nfebe @AndyScherzinger
    nfebe authored and AndyScherzinger committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    8a67fc4 View commit details
    Browse the repository at this point in the history

  3. chore(assets): Recompile assets 

    Signed-off-by: nextcloud-command <[email protected]>
    @nextcloud-command @AndyScherzinger
    nextcloud-command authored and AndyScherzinger committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    06eda7a View commit details
    Browse the repository at this point in the history