feat(dav): dispatch out-of-office started and ended events #41440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
2 tasks
st3iny
force-pushed
the
feat/dav/out-of-office-job
branch
from
66c089d
to
1f3ef66
Compare
I'm looking into this now |
|
TZ handling based on a cleaned-up version of #41461 added. It's a bit messy to have to fetch the current timezone setting everywhere, OTOH this allows the tz to move with the user, should it ever change. Tests will need adjustment. Looking into that shortly. |
| * @method string getPropertyname() | ||
| * @method string getPropertyvalue() | ||
| */ | ||
| class Property extends Entity { |
Check notice
Code scanning / Psalm
PropertyNotSetInConstructor Note
|
Psalm and tests should be happy now |
ChristophWurst
added
3. to review
apps/dav/lib/BackgroundJob/OutOfOfficeEventDispatcherJob.php
Dismissed
Show dismissed
Hide dismissed
Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
commented
Nov 23, 2023
ChristophWurst
force-pushed
the
feat/dav/out-of-office-job
branch
from
ea0dbb4
to
8191295
Compare
This was referenced Nov 23, 2023
|
Merging because the 28 backport is in too |
ChristophWurst
removed
the
pending documentation
5 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new queued job that emits events when a out-of-office period of a user begins and ends.
TODO
How to smoke test
\OCA\DAV\BackgroundJob\OutOfOfficeEventDispatcherJob, note its idphp occ background-job:execute <id> --force-executeChecklist