Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(systemtags): Add accessible system tags form #41335

Merged
merged 8 commits into from
Nov 16, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Nov 8, 2023

Summary

Screenshot
Before image
After image

To Do

  • Tests

Checklist

@Pytal Pytal added this to the Nextcloud 28 milestone Nov 8, 2023
@Pytal Pytal self-assigned this Nov 8, 2023
@blizzz blizzz mentioned this pull request Nov 8, 2023
@JuliaKirschenheuter
Copy link
Contributor

😱 would need time to review

Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine.

But from a11y perspective, I'm not sure that this is clear when this form is at the same time create and edit form, especially when searching a tag to edit is a part of the form.

@Pytal

This comment was marked as resolved.

This was referenced Nov 10, 2023
@Pytal Pytal force-pushed the enh/a11y/admin-collab-tags branch 4 times, most recently from f670fa6 to ca35ea7 Compare November 16, 2023 02:30
@Pytal Pytal merged commit 50f8d6c into master Nov 16, 2023
49 of 51 checks passed
@Pytal Pytal deleted the enh/a11y/admin-collab-tags branch November 16, 2023 04:52
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility feature: tags
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants