-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh(systemtags): Add accessible system tags form #41335
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
😱 would need time to review |
ShGKme
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works fine.
But from a11y perspective, I'm not sure that this is clear when this form is at the same time create and edit form, especially when searching a tag to edit is a part of the form.
This comment was marked as resolved.
This comment was marked as resolved.
Pytal
force-pushed
the
enh/a11y/admin-collab-tags
branch
from
November 9, 2023 00:33
4b2e938
to
3516f93
Compare
susnux
approved these changes
Nov 9, 2023
JuliaKirschenheuter
approved these changes
Nov 9, 2023
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Pytal
force-pushed
the
enh/a11y/admin-collab-tags
branch
4 times, most recently
from
November 16, 2023 02:30
f670fa6
to
ca35ea7
Compare
Signed-off-by: Christopher Ng <[email protected]>
Pytal
force-pushed
the
enh/a11y/admin-collab-tags
branch
from
November 16, 2023 02:34
ca35ea7
to
470f825
Compare
Pytal
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Nov 16, 2023
This was referenced Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To Do
Checklist