fix semaphore unguarding #41263
Merged
fix semaphore unguarding #41263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon L <[email protected]>
szaimen
requested review from
st3iny,
juliusknorr,
kesselb,
a team,
ArtificialOwl,
icewind1991 and
sorbaugh
and removed request for
a team
|
/backport to stable27 |
|
/backport to stable26 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
kesselb
reviewed
Nov 3, 2023
Signed-off-by: Simon L <[email protected]>
kesselb
approved these changes
Nov 3, 2023
|
CI failure unrelated |
Sorry, saw it too late |
|
Noted |
|
/backport to stable27 |
|
/backport to stable26 |
|
The backport bot is dead again 😭 |
This was referenced Nov 5, 2023
Merged
8 tasks
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently sem_get returns a SysvSemaphore class and not a resource anymore. See https://www.php.net/manual/en/function.sem-get.php