Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dav): multiple fixes in usage of webdav library #41202

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

pulsejet
Copy link
Member

  1. Refresh token on update
  2. Fix some very weird imports
  3. Patch fetch instead of request to prevent accessing impl details

@pulsejet pulsejet added 3. to review Waiting for reviews javascript labels Oct 30, 2023
@pulsejet pulsejet added this to the Nextcloud 28 milestone Oct 30, 2023
pulsejet added a commit to pulsejet/nextcloud-files that referenced this pull request Oct 30, 2023
@skjnldsv
Copy link
Member

  1. Patch fetch instead of request to prevent accessing impl details

Can you clarify what is this about? :)

pulsejet added a commit to pulsejet/nextcloud-files that referenced this pull request Oct 31, 2023
pulsejet added a commit to pulsejet/nextcloud-files that referenced this pull request Oct 31, 2023
@pulsejet pulsejet force-pushed the pulsejet/fix-webdav branch 2 times, most recently from 3a50a40 to 59c544c Compare October 31, 2023 17:58
@pulsejet
Copy link
Member Author

  1. Patch fetch instead of request to prevent accessing impl details

Can you clarify what is this about? :)

To patch request, we need

import { request } from 'webdav/dist/node/request.js'

This is an implementation detail of the webdav library and also needs the node polyfills. Instead we can just patch fetch which is equivalent since request just calls fetch with the same options (and we're just changing the method anyway).

BTW, fixed the style to align with nextcloud-files

@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
This was referenced Nov 6, 2023
This was referenced Nov 14, 2023
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@pulsejet
Copy link
Member Author

pulsejet commented Nov 24, 2023

I want to point out that things might be broken without this patch in 28. When the refresh token changes, the WebDAV clients are never updated in RC.1

This is not a feature, it's a fix to a regression.

@pulsejet
Copy link
Member Author

/compile amend /

@pulsejet pulsejet force-pushed the pulsejet/fix-webdav branch 4 times, most recently from a8cde62 to 410bddd Compare November 28, 2023 21:08
@pulsejet
Copy link
Member Author

CI failure seems unrelated

1. Refresh token on update
2. Fix some very weird imports
3. Patch fetch instead of request to prevent accessing impl details

Signed-off-by: Varun Patil <[email protected]>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 28, 2024
@skjnldsv skjnldsv merged commit 281c8a4 into master Feb 28, 2024
99 checks passed
@skjnldsv skjnldsv deleted the pulsejet/fix-webdav branch February 28, 2024 21:18
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish javascript regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants