enh(SpeechToText): Allow providers to declare a dynamic ID instead of using className #41087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelklehr
requested review from
juliusknorr,
julien-nc,
bigcat88 and
andrey18106
|
(I'm sort of sad about the beauty we lose with this, but alas) |
6 tasks
Merged
… using className this allows AppAPI to register anonymous classes as SpeechToText providers Signed-off-by: Marcel Klehr <[email protected]>
marcelklehr
force-pushed
the
enh/stt-provider-with-id
branch
from
1c5411e
to
928fee8
Compare
|
Please review |
andrey18106
approved these changes
Dec 19, 2023
bigcat88
approved these changes
Dec 19, 2023
Signed-off-by: Marcel Klehr <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows AppAPI to register anonymous classes as SpeechToText providers
see nextcloud/app_api#60
Checklist