fix(objectstorage): cleanup HomeObjectStoreStorage #40981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcitworld
requested review from
icewind1991,
juliusknorr,
come-nc,
a team and
blizzz
and removed request for
a team
come-nc
approved these changes
Oct 19, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tcitworld
force-pushed
the
fix/object-storage-user
branch
from
5528f3c
to
b756640
Compare
juliusknorr
approved these changes
Oct 20, 2023
|
Psalm still has some complaints though |
Merged
tcitworld
force-pushed
the
fix/object-storage-user
branch
from
b756640
to
e7b709d
Compare
|
Rebased |
|
CI failes |
Fix invalid signature for getUser() method and change occurences of OC\User\User for OCP\IUser Signed-off-by: Thomas Citharel <[email protected]>
…class to HomeObjectStoreStorage Signed-off-by: Thomas Citharel <[email protected]>
Signed-off-by: Thomas Citharel <[email protected]>
tcitworld
force-pushed
the
fix/object-storage-user
branch
from
e7b709d
to
30798eb
Compare
Unrelated to this PR (17ee596), this rebase should work fine. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix invalid signature for
getUser()method and change occurrences ofOC\User\UserforOCP\IUser(unless there's a good reason for that?)Checklist