Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix text on default background image button #40804

Merged
merged 1 commit into from
Oct 9, 2023
Merged

fix text on default background image button #40804

merged 1 commit into from
Oct 9, 2023

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Oct 6, 2023 •
edited
Loading

Close #40687

Before After
image image

@szaimen szaimen added this to the Nextcloud 28 milestone Oct 6, 2023
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 6, 2023
@szaimen szaimen marked this pull request as ready for review October 6, 2023 15:32
@Pytal Pytal requested a review from skjnldsv October 7, 2023 01:06
@szaimen
Copy link
Contributor Author

szaimen commented Oct 9, 2023

/compile amend /

@szaimen szaimen enabled auto-merge October 9, 2023 15:41
@szaimen @nextcloud-command
fix text on default background image button
8799c68 
Signed-off-by: Simon L <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@szaimen
Copy link
Contributor Author

szaimen commented Oct 9, 2023

CI failure unrelated

@szaimen szaimen disabled auto-merge October 9, 2023 18:52
@szaimen szaimen merged commit c40ece3 into master Oct 9, 2023
37 of 40 checks passed
@szaimen szaimen deleted the enh/40687/fix-button-text branch October 9, 2023 18:52
@JuliaKirschenheuter JuliaKirschenheuter mentioned this pull request Oct 25, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShGKme ShGKme ShGKme approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@susnux susnux Awaiting requested review from susnux

@Pytal Pytal Awaiting requested review from Pytal

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review Waiting for reviews accessibility enhancement
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

[BITV]: "Default background" title is not visible on background buttons
3 participants
@szaimen @JuliaKirschenheuter @ShGKme