Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read apporder from configuration value #40617

Merged
merged 7 commits into from
Sep 28, 2023
Merged

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Sep 25, 2023

Summary

Backend for allowing users to set apporder.

  • First application also be set as default app if no default app was set
  • Allow admin to provide default order
  • Allow admin to force default order

Checklist

@come-nc come-nc added this to the Nextcloud 28 milestone Sep 25, 2023
@come-nc come-nc self-assigned this Sep 25, 2023
@come-nc

This comment was marked as outdated.

@come-nc come-nc requested a review from susnux September 26, 2023 14:29
@come-nc come-nc added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 26, 2023
@come-nc come-nc requested review from a team, ArtificialOwl, icewind1991 and nfebe and removed request for a team September 26, 2023 14:39
@susnux
Copy link
Contributor

susnux commented Sep 27, 2023

@come-nc this error seems to be related:


There were 3 failures:

1) Test\UrlGeneratorTest::testLinkToDefaultPageUrlWithRedirectUrlRedirectBypassWithoutFrontController
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'http://localhost/index.php/apps/dashboard/'
+'http://localhost/index.php/apps/files/'

/drone/src/tests/lib/UrlGeneratorTest.php:243

2) Test\UrlGeneratorTest::testLinkToDefaultPageUrlWithRedirectUrlRedirectBypassWithFrontController
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'http://localhost/apps/dashboard/'
+'http://localhost/apps/files/'

/drone/src/tests/lib/UrlGeneratorTest.php:252

3) Test\UrlGeneratorTest::testLinkToDefaultPageUrlWithRedirectUrlWithIgnoreFrontController
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'http://localhost/apps/dashboard/'
+'http://localhost/apps/files/'

/drone/src/tests/lib/UrlGeneratorTest.php:261

--

@come-nc come-nc marked this pull request as ready for review September 28, 2023 07:11
@come-nc come-nc merged commit c9ed1e9 into master Sep 28, 2023
35 of 37 checks passed
@come-nc come-nc deleted the enh/allow-user-to-set-apporder branch September 28, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants