Add in:users as a search filter to limit searches to users #40413
Conversation
AndyScherzinger
changed the title
|
/backport to stable27 |
|
/backport to stable26 |
|
/backport to stable25 |
sorbaugh
force-pushed
the
feature/sorbaugh/in-user-search
branch
from
bf15926
to
2f37665
Compare
AndyScherzinger
force-pushed
the
feature/sorbaugh/in-user-search
branch
from
3999dbf
to
280a178
Compare
|
/compile amend / |
nextcloud-command
force-pushed
the
feature/sorbaugh/in-user-search
branch
from
280a178
to
82e2a50
Compare
| $this->settingsManager = $settingsManager; | ||
| $this->groupManager = $groupManager; | ||
| $this->urlGenerator = $urlGenerator; | ||
| $this->userManager = $userManager; | ||
| $this->accountManager = $accountManager; |
There was a problem hiding this comment.
Maybe I am overseeing something, but they are all not being used?
There was a problem hiding this comment.
Cleaned this one up, thanks for pointing it out 👍
|
|
||
| return SearchResult::complete( | ||
| $this->l->t('Users'), | ||
| [] |
There was a problem hiding this comment.
Do I understand how it works correctly, that this search plugin intentionally returns an empty result set? For users page it make sense as results are shown on the content and not in the pull down. Maybe I am misinterpreting how that search works though.
The naming would block potential valid future searches for users, although there is the contacts menu for this. It's acceptable, but want to point it out.
There was a problem hiding this comment.
Yes I agree this is somewhat strange. ATM the main goal is for a customer to more efficiently search for contacts without triggering everything. You correctly pointed out that the goal is to not have a list of users shown in the pulldown. See commit where how this used to be solved (and how we want to revisit in the future)
sorbaugh
force-pushed
the
feature/sorbaugh/in-user-search
branch
2 times, most recently
from
3194f6b
to
f712098
Compare
|
/compile / |
Add regex to prevent filter collision in user-list page Usage: 1. Type a string in the search bar 2. Add in:users to display only users in the search result
…chlist dialog. Will revisit in future search result list in future issue. Usage: 1. Type a string in the search bar 2. Add in:users filter to avoid unnecessary searches in other apps
Usage: 1. Type a string in the search bar 2. Add in:users filter to avoid unnecessary searches in other apps
Signed-off-by: nextcloud-command <[email protected]>
Signed-off-by: sorbaugh <[email protected]>
AndyScherzinger
force-pushed
the
feature/sorbaugh/in-user-search
branch
from
7dea2a4
to
bdf0fe6
Compare
|
/compile / |
Signed-off-by: nextcloud-command <[email protected]>
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
/backport ab81cd1,65c70d7cc6425af0bf202d70c67eabd579d913a6,c38bafba9e13e4e735ed2d6698b6c4f5d9efc7d5,a3a599855e20b60627ac4e65fed8fdfa6b2c04f8,f66e4ee07246b285f79173c300de943b3a857bad,bdf0fe6a03beccc58a119f05d9cdb7ab643ebcfd to stable27 |
|
Backportbot seems to have day off :-/ fastest to do it manually it seems |
|
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
1 similar comment
|
The backport to stable27 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable27
git pull origin stable27
# Create the new backport branch
git checkout -b fix/foo-stable27
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
|
The backport to stable26 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable26
git pull origin stable26
# Create the new backport branch
git checkout -b fix/foo-stable26
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
|
The backport to stable25 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable25
git pull origin stable25
# Create the new backport branch
git checkout -b fix/foo-stable25
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
in:usersas a search filter to limit searches to users #40287Summary
Add in:users filter to search bar via SearchProvider to have a mechanism to limit the search load in settings/users.
TODO
Checklist