fix(f2v): Files list loading with special chars in uid #40313
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndyScherzinger
approved these changes
Sep 7, 2023
artonge
approved these changes
Sep 7, 2023
skjnldsv
requested changes
Sep 7, 2023
Pytal
added
2. developing
Pytal
changed the title
|
Now correctly encodes single quotes as defined in server/lib/private/User/Manager.php Line 706 in eb55101 |
Pytal
added
3. to review
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
skjnldsv
reviewed
Sep 8, 2023
| const client = createClient(rootUrl, { | ||
| // Encode valid user id characters | ||
| const encodedUrl = encodeURI(rootUrl) | ||
| .replaceAll('\'', '%27') |
There was a problem hiding this comment.
We should not have to replace quotes, they are allowed in an URL according to rfc2396
I think the webdav have an issue. Here are the exact two same requests:
| Without quote in userId | With quote in userId |
|---|---|
 |
 |
Merged
Merged
|
Superseded by perry-mitchell/webdav-client#360 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
…/dav/files/test user/→…/dav/files/test%20user/Checklist