Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable new versions feature for groupfolders #40296

Merged
merged 3 commits into from
Sep 7, 2023

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Sep 6, 2023

New

  • Some logic that should have been part of the main version backend were in the shared logic. So I created a INeedSyncVersionBackend interface to discriminate backends that need to update their DB on some node events. The main backend and the groupfolders backend both need it.
  • Unlock the frontend to allow access to the new versions features for groupfolders
  • Fix naming the current version, it was lost when working on opening versions in the viewer.

Todo

  • Check tests

Note

This PR is kept before F2V on purpose to make it easier to test.

@artonge artonge added bug enhancement 3. to review Waiting for reviews feature: versions php Pull requests that update Php code labels Sep 6, 2023
@artonge artonge added this to the Nextcloud 28 milestone Sep 6, 2023
@artonge artonge self-assigned this Sep 6, 2023
@artonge artonge changed the title Artonge/feat/enable files versions for groupfolders Enable new versions feature for groupfolders Sep 6, 2023
@artonge artonge force-pushed the artonge/feat/enable_files_versions_for_groupfolders branch 2 times, most recently from c35459a to d1b5d9b Compare September 7, 2023 07:32
@artonge
Copy link
Contributor Author

artonge commented Sep 7, 2023

/backport to stable27

We only need to change the filename
of the current version for the viewer

Signed-off-by: Louis Chemineau <[email protected]>
@artonge artonge force-pushed the artonge/feat/enable_files_versions_for_groupfolders branch from 6f80ae2 to 52ceb40 Compare September 7, 2023 13:48
@artonge
Copy link
Contributor Author

artonge commented Sep 7, 2023

Failing test is unrelated

@artonge artonge merged commit fdf752f into master Sep 7, 2023
38 checks passed
@artonge artonge deleted the artonge/feat/enable_files_versions_for_groupfolders branch September 7, 2023 19:53
@backportbot-nextcloud

This comment was marked as outdated.

@artonge
Copy link
Contributor Author

artonge commented Sep 7, 2023

/backport to stable27

@backportbot-nextcloud

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request bug enhancement feature: versions php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants