-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable new versions feature for groupfolders #40296
Merged
artonge
merged 3 commits into
master
from
artonge/feat/enable_files_versions_for_groupfolders
Sep 7, 2023
Merged
Enable new versions feature for groupfolders #40296
artonge
merged 3 commits into
master
from
artonge/feat/enable_files_versions_for_groupfolders
Sep 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
added
bug
enhancement
3. to review
Waiting for reviews
feature: versions
php
Pull requests that update Php code
labels
Sep 6, 2023
artonge
changed the title
Artonge/feat/enable files versions for groupfolders
Enable new versions feature for groupfolders
Sep 6, 2023
2 tasks
AndyScherzinger
approved these changes
Sep 6, 2023
artonge
force-pushed
the
artonge/feat/enable_files_versions_for_groupfolders
branch
2 times, most recently
from
September 7, 2023 07:32
c35459a
to
d1b5d9b
Compare
/backport to stable27 |
come-nc
approved these changes
Sep 7, 2023
Signed-off-by: Louis Chemineau <[email protected]>
Signed-off-by: Louis Chemineau <[email protected]>
We only need to change the filename of the current version for the viewer Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/feat/enable_files_versions_for_groupfolders
branch
from
September 7, 2023 13:48
6f80ae2
to
52ceb40
Compare
Failing test is unrelated |
artonge
deleted the
artonge/feat/enable_files_versions_for_groupfolders
branch
September 7, 2023 19:53
This comment was marked as outdated.
This comment was marked as outdated.
/backport to stable27 |
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Sep 7, 2023
juliusknorr
reviewed
Sep 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
backport-request
bug
enhancement
feature: versions
php
Pull requests that update Php code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
INeedSyncVersionBackend
interface to discriminate backends that need to update their DB on some node events. The main backend and the groupfolders backend both need it.Todo
Note
This PR is kept before F2V on purpose to make it easier to test.