Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor OC\Server::getAvatarManager in dav app #40207

Conversation

summersab
Copy link
Contributor

This PR refactors the deprecated method OC\Server::getAvatarManager and replaces it with OC\Server::get(\OCP\IAvatarManager::class) in the dav app.

Additionally, where necessary, the \OCP\IAvatarManager class is imported via the use directive.

This PR will be submitted once #40114 is approved.

@summersab summersab force-pushed the refactor/apps/dav/OC-Server-getAvatarManager branch 2 times, most recently from 37c5d07 to 32a3e7f Compare September 7, 2023 18:56
@summersab summersab marked this pull request as ready for review September 7, 2023 18:56
@solracsf solracsf added this to the Nextcloud 28 milestone Nov 21, 2023
@blizzz blizzz mentioned this pull request Nov 22, 2023
5 tasks
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@skjnldsv skjnldsv added the 2. developing Work in progress label Feb 21, 2024
This was referenced Mar 12, 2024
This was referenced Mar 20, 2024
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
81 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024
@skjnldsv skjnldsv requested review from a team, ArtificialOwl, icewind1991 and sorbaugh and removed request for a team May 30, 2024 12:14
@skjnldsv skjnldsv added 3. to review Waiting for reviews technical debt and removed 2. developing Work in progress labels May 30, 2024
@skjnldsv skjnldsv force-pushed the refactor/apps/dav/OC-Server-getAvatarManager branch from 32a3e7f to 7a887b4 Compare May 30, 2024 12:14
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 30, 2024
@skjnldsv skjnldsv merged commit db4aaf4 into nextcloud:master May 30, 2024
146 of 154 checks passed
@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants