test: remove broken steps from files acceptance test #39778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
force-pushed
the
acceptance-test-files
branch
from
7e90400
to
980533b
Compare
kesselb
changed the title
kesselb
added
3. to review
szaimen
approved these changes
Aug 9, 2023
Good idea. I copied the commit message to the behat scenario. |
kesselb
force-pushed
the
acceptance-test-files
branch
from
980533b
to
78b6e84
Compare
szaimen
approved these changes
Aug 9, 2023
Pytal
approved these changes
Aug 9, 2023
The acceptance tests using the recent view fail since the vue migration. `And I open the details view for "welcome.txt"` Is looking for a row in the filelist with a span having the class nametext, matching the file name "welcome.txt" and button inside having the class action-menu. The markup for the files list looks very different after the vue migration and therefor the test is failing. Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb
force-pushed
the
acceptance-test-files
branch
from
78b6e84
to
d56e2aa
Compare
skjnldsv
approved these changes
Aug 10, 2023
|
CI failure unrelated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The acceptance tests using the recent view fail since the vue migration.
And I open the details view for "welcome.txt"Is looking for a row in the filelist with a span having the class nametext, matching the file name "welcome.txt" and button inside having the class action-menu.
The markup for the files list looks very different after the vue migration and therefor the test is failing.
The test case:
I assume we can enable it again, once everything is using the FilesEntry component after adjusting the css selectors.
If the actual test is useful for something and was not replaced by a shiny new cypress test ;)
TODO
Checklist